[Ruby 3.0 support] Assigning to numbered parameter #2506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrykonchin
commented
Oct 17, 2021
| : node.getPosition(); | ||
| warnNumberedParameterLikeDeclaration(position, name); | ||
| // assigning to a numbered parameter is a SyntaxError | ||
| throw compile_error(name + " is reserved for numbered parameter"); |
There was a problem hiding this comment.
TBH I am not sure whether it's a safe change. I just have found a place where the proper warning is printed in the proper situation (and it fixes the added specs).
Also, the else branch with throw compile_error("Can't assign to numbered parameter " + name); looks pretty suspicious and looks like covers quite a similar case.
There was a problem hiding this comment.
It looks fine, and the change is indeed AFAIK the warning is replaced by an error.
eregon
approved these changes
Oct 18, 2021
| : node.getPosition(); | ||
| warnNumberedParameterLikeDeclaration(position, name); | ||
| // assigning to a numbered parameter is a SyntaxError | ||
| throw compile_error(name + " is reserved for numbered parameter"); |
There was a problem hiding this comment.
It looks fine, and the change is indeed AFAIK the warning is replaced by an error.
eregon
force-pushed
the
ruby-3-0-support-assigning-to-numbered-parameter
branch
from
c6f6cef to
cad8cba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses
Related issue - #2453
Changes: