-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ruby 3.0 support] Add support for Array subclass methods to return Array #2510
[Ruby 3.0 support] Add support for Array subclass methods to return Array #2510
Conversation
You're welcome to ask any question on Slack :) |
Sorry about the incorrect classification as |
@eregon Thanks for the review and tips, definitely helps! I've resolved all the notes, but I have some doubts about one where I should return the comment in place 🤔 |
3ff6672
to
15d2f59
Compare
👋🏼 Hola @eregon may I ask for one more review? I've applied all the tips you gave me and seems all check passed (but before I squash everything and pushed) |
Could you rebase to latest master? When you do, just drop the changes to |
Ah and instead of |
4ba1774
to
01859b6
Compare
1c51824
to
2c7cc10
Compare
Thank you one more time @eregon. All fixes were applied |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
This PR will add adjust Array that its subclasses on below methods return Array (from the Ruby 3.0 support #2453)
I find out that for
Array.slice
I would need to adjust Java code. I will dig a bit to get the context around, but I probably would need some help (or an example)