Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Range#step with begin-less range returns correct ArithmeticSequence #2516

Merged
merged 4 commits into from
Oct 28, 2021
Merged

Range#step with begin-less range returns correct ArithmeticSequence #2516

merged 4 commits into from
Oct 28, 2021

Conversation

ccocchi
Copy link
Contributor

@ccocchi ccocchi commented Oct 27, 2021

Fixes #2514

@ccocchi ccocchi force-pushed the fix_range_class branch 2 times, most recently from e586b21 to cd3b2cb Compare October 28, 2021 09:55
eregon
eregon approved these changes Oct 28, 2021
View reviewed changes
Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks great!

spec/ruby/core/range/step_spec.rb Show resolved Hide resolved
@eregon eregon added the in-ci The PR is being tested in CI. Do not push new commits. label Oct 28, 2021
@eregon eregon added this to the 22.0.0 milestone Oct 28, 2021
@graalvmbot graalvmbot merged commit ede71a4 into oracle:master Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eregon eregon eregon approved these changes

Assignees
No one assigned
Labels
in-ci The PR is being tested in CI. Do not push new commits. oca-signed
Projects
None yet
Milestone
22.0.0
Development

Successfully merging this pull request may close these issues.

Begin-less range with step not returning the correct class
3 participants
@ccocchi @eregon @graalvmbot