-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When writing to STDOUT redirected to a closed pipe, no broken pipe #2532
When writing to STDOUT redirected to a closed pipe, no broken pipe #2532
Conversation
apparently I broke other EPIPE related tests @eregon |
This is part of the Ruby 3.0 changes:
|
Not sure how to write test for it |
db1303d
to
def60be
Compare
@gogainda One way is to look at the CRuby test to see how it's tested. I'll write a spec for it this time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
@eregon is there anything I can do to move this PR forward? |
Sorry, I somehow lost sight of this PR, it looks like it didn't merge due to a new CI job being added and it didn't automatically run it. |
error message will be shown now
84008cd
to
203ea08
Compare
Actually there are two MRI tests failing:
|
d6b5e5a
to
076f00e
Compare
* It seems that reopen clears the flag to raise SIGPIPE instead of EPIPE, see oracle#2532
I'll just tag that test for now, it seems a weird edge case with |
error message will be shown now
Ruby commit ruby/ruby@6f28ebd
before
after
only problem I found is that -n is not working on truffleruby, so I don't know how it behaves with this fix