Add semicolon to the buffer atime assignment

[Strech]

I just accidentally found a forgotten ; while compiling it on M1

[chrisseaton]

We'd have already fixed this if we merged my PR!

#2633

[Strech]

@chrisseaton Oh, thanks for pointing out. Should I keep this PR open or ...?

[chrisseaton]

Sore that comment was for the reviewers of this PR, rather than directed at you.

[Strech]

We can co-authored it 😄 I think it might be tough to push a big change, but this mistype is clearly the small fix we can just merge without much hassle ✌🏼

[chrisseaton]

It's great for you to author this PR and get it merged - I'm just saying to the wider team that this was already fixed if we'd merged it rather than deferring the work.

[eregon]

This sounds like an incorrect lib/cext/include/truffleruby/config_darwin_aarch64.h header used.
I'd think darwin-aarch64 should have at least one of these 3 HAVE_STRUCT_STAT_ST_ATIM* defines set.

How did you create your lib/cext/include/truffleruby/config_darwin_aarch64.h, or did you modify config.h?
It should have errored earlier if missing:

truffleruby/lib/cext/include/ruby/config.h

Line 7 in c5dcfbd

#error Unsupported platform

This is why I want proper darwin-aarch64 support and not partial patches, otherwise people build it and find it's half broken.
I want something tested in CI and correct, that's why I closed #2633.
It's nearly ready, see #2657

[eregon]

We can of course add the missing ;, but it seems it's really just the side effect of something more fundamentally broken/hacked to hit that path (maybe it should be an #error instead).

[Strech]

How did you create your lib/cext/include/truffleruby/config_darwin_aarch64.h, or did you modify config.h?
It should have errored earlier if missing:

It was giving me Unsupported platform error only after I've manually fixed a semicolon issue

[eregon]

I tried to repro it locally with

diff --git a/lib/cext/include/ruby/config.h b/lib/cext/include/ruby/config.h
index 9f4c3bd5b5..a0b7fd2083 100644
--- a/lib/cext/include/ruby/config.h
+++ b/lib/cext/include/ruby/config.h
@@ -9,7 +9,7 @@
 
 #else
 
-#if defined(__x86_64__)
+#if defined(__x86_64__) && 0
 #include <truffleruby/config_linux_amd64.h>
 #elif defined(__aarch64__)
 #include <truffleruby/config_linux_aarch64.h>

That gives:

Building org.truffleruby.cext with GNU Make... [rebuild needed by GNU Make]
make[1]: Entering directory '/home/eregon/code/truffleruby-ws/truffleruby/src/main/c/truffleposix'
In file included from truffleposix.c:44:
/home/eregon/code/truffleruby-ws/truffleruby/lib/cext/include/ruby/config.h:17:2: error: Unsupported platform
#error Unsupported platform
 ^
truffleposix.c:470:25: error: expected ';' after expression
  buffer->atime_nsec = 0
                        ^
                        ;
2 errors generated.

So clang (from the toolchain) shows both errors at the same time, and so keeps compiling even though a header errored.
I guess there is nothing we can do about that, except maybe knowing it's always worth fixing the first error before looking at the other errors.

Now that I understand how this error is seen, I'll merge this and a couple more cleanups to truffleposix.c.