Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two minor fixes #2662

Closed
wants to merge 2 commits into from
Closed

Two minor fixes #2662

wants to merge 2 commits into from

Conversation

chrisseaton
Copy link
Collaborator

No description provided.

@chrisseaton
Copy link
Collaborator Author

Needs tests.

@eregon
Copy link
Member

eregon commented May 25, 2022

For the 3rd issue, a simple repro is:

ruby 3.0.3p157 (2021-11-24 revision 3fb7d2cadc) [x86_64-linux]
1
~ ∴ chruby dev                                                 
~ ∴ ruby -v -rbigdecimal -e 'p BigDecimal.method(:_load).arity'
truffleruby 22.2.0-dev-e2f62b89, like ruby 3.0.3, GraalVM CE Native [x86_64-linux]
-1

@eregon
Copy link
Member

eregon commented May 26, 2022

@chrisseaton Do you have local changes on this branch (if so please push them)?
I can take care of the tests and the 3rd issue mentioned just above.

@chrisseaton
Copy link
Collaborator Author

No I don't think we wrote anything else did we? There was the change to Paquito, but that was just to work around the BigDecimal arity bug.

@eregon
Copy link
Member

eregon commented May 26, 2022

OK, I'm happy to integrate these fixes and add tests then.

@eregon
Copy link
Member

eregon commented May 27, 2022

For the first issue (-Werror in C exts), I created #2664
For the second, #2665
For the third and last one: #2666

@eregon
Copy link
Member

eregon commented May 27, 2022

All done now, I'll close this and we'll just need to merge those 3 PRs linked above.

@eregon eregon closed this May 27, 2022
graalvmbot pushed a commit that referenced this pull request May 27, 2022
graalvmbot pushed a commit that referenced this pull request May 27, 2022
@eregon
Copy link
Member

eregon commented May 27, 2022

All 3 fixes merged now.

@chrisseaton chrisseaton deleted the fixes branch December 1, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants