Adjust Process.egid= to accept Strings
#2669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngtban
changed the title
Process.egid= to accept StringsProcess.egid= to accept Strings
bjfish
reviewed
Jun 8, 2022
bjfish
reviewed
Jun 8, 2022
bjfish
reviewed
Jun 8, 2022
|
Could you also add a changelog entry? (see CONTRIBUTING.md) |
eregon
reviewed
Jun 16, 2022
spec/ruby/core/process/egid_spec.rb
Outdated
| as_superuser do | ||
| context "when ran by a superuser" do | ||
| it "sets the effective group id for the current process if run by a superuser" do | ||
| Process.egid = 1 |
There was a problem hiding this comment.
This seems way too dangerous as a side-effect, could you restore the original egid in ensure?
There was a problem hiding this comment.
I'll do it, to avoid another feedback cycle.
eregon
approved these changes
Jun 16, 2022
|
Thank you for the PR, I'll submit it to the merge queue now. |
eregon
force-pushed
the
2615-proc-set-egid
branch
from
dfc920f to
fe1a8ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Process.egid=to accept strings (Process.euid=/Process.egid= don't accept strings #2615, @ngtban)