Reduce empty array allocations #3517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
nirvdrum
added
shopify
and removed
OCA Verified
eregon
reviewed
Apr 2, 2024
src/main/java/org/truffleruby/core/array/MultipleAssignmentNode.java
Outdated
Show resolved
Hide resolved
src/main/java/org/truffleruby/language/arguments/CheckKeywordArityNode.java
Outdated
Show resolved
Hide resolved
…bles from an object without any instance variables.
… pre- or post- node argument lists are empty.
nirvdrum
force-pushed
the
reduce-empty-array-memory
branch
from
9c9d5b9 to
5a270b8
Compare
oracle-contributor-agreement
bot
added
the
OCA Verified
andrykonchin
added
the
in-ci
eregon
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking a heap dump taken from a load test against a Rails 7.1 application, I saw thousands of empty array allocations. I don't think these amount to much more than a few megabytes of memory, but eliminating them was easy and it cleans up the profile a bit.