Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dedicated NoMoreSegmentsException to signal end of .hprof file #378

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -1242,7 +1242,7 @@ private TagBounds computeHeapDumpStart() throws IOException {
start = offset[0];
}

throw new IOException("Invalid segment " + segment); // NOI18N
throw new NoMoreSegmentsException(segment);
} else {
TagBounds heapDumpSegmentBounds = tagBounds[HEAP_DUMP_SEGMENT];

Expand Down Expand Up @@ -1272,7 +1272,7 @@ private TagBounds computeHeapDumpStart() throws IOException {

start = offset[0];
}
throw new IOException("Invalid segment " + segment); // NOI18N
throw new NoMoreSegmentsException(segment);
}
}
return null;
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
/*
* Copyright (c) 1997, 2022, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation. Oracle designates this
* particular file as subject to the "Classpath" exception as provided
* by Oracle in the LICENSE file that accompanied this code.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/

package org.graalvm.visualvm.lib.jfluid.heap;

import java.io.IOException;

final class NoMoreSegmentsException extends IOException {
private final int segment;

NoMoreSegmentsException(int segment) {
super("Invalid segment " + segment); // NOI18N
this.segment = segment;
}

int getSegment() {
return segment;
}
}