Update for PHP 8.1 support #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Jacob Baker-Kretzmar <18192441+bakerkretzmar@users.noreply.github.com>
jdreesen
reviewed
Dec 8, 2021
jdreesen
reviewed
Dec 8, 2021
2 tasks
Co-authored-by: Jacob Dreesen <jacob@hdreesen.de>
Co-authored-by: Jacob Dreesen <jacob@hdreesen.de>
|
Thanks for the contribution. My Travis CI has ran out of credits. I've requested for some OSS credits I assume this won't work on older versions of PHP. We can see once Travis CI builds the PR |
theofidry
approved these changes
Dec 9, 2021
|
reopening the PR so Travis CI build is triggered |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The return types are pretty clear here, but we weren't sure the preferred behavior for the
null$configOption, whether it would be to enforce strings, or do the following behavior.(PR'ed to support humbug/php-scoper updating to support 8.1: humbug/php-scoper#530)