Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow symfony/console 6.* #40

Closed
wants to merge 1 commit into from
Closed

Allow symfony/console 6.* #40

wants to merge 1 commit into from

Conversation

ddebin
Copy link
Contributor

@ddebin ddebin commented May 6, 2022

A Symfony 6.0+ test is required because of function signatures change in Console\Application.
Maybe a better test exists instead of Runtime Composer utilities.

@ddebin ddebin force-pushed the master branch 5 times, most recently from 772c94b to 573fa69 Compare May 6, 2022 14:43
@oradwell
Copy link
Owner

oradwell commented May 6, 2022

Thanks for your PR @ddebin
what I'd do is to define it as a separate class (CoversValidatorSymfony5 and CoversValidatorSymfony6) and use class_alias. that way you don't need to put class definitions in if statements
I did something similar in FileTestCase.php#L7

I've also asked Travis-CI for more Open Source credits

@oradwell oradwell closed this May 7, 2022
@oradwell oradwell reopened this May 7, 2022
@coveralls
Copy link

Coverage Status

Coverage decreased (-7.7%) to 86.29% when pulling ed45648 on ddebin:master into 70d5d4b on oradwell:master.

@oradwell
Copy link
Owner

merged in #41

@oradwell oradwell closed this Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants