-
-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RangeError: Maximum call stack size exceeded #506
Comments
Hey, thanks for opening the issue. Are you willing to open a PR to fix this issue? We can ping Michele to give priority once the PR is landed. You can use this function and change all the references for orama/packages/orama/src/utils.ts Lines 20 to 37 in 13ef4c4
|
I would really appreciate a PR for fixing this. I would definitely give this high priority |
I've prepared a branch with the fix. Should I get a permissions for the repository?
|
You should create a pull request, first fork this project, and then push your changes inside a new branch of your fork. Then, you will see a button on the main page of your fork to create and compare a pull request against the main repo. See more: https://docs.github.com/en/get-started/quickstart/contributing-to-projects |
PR is ready |
Hi, |
Fixed in v1.2.10 |
The bug
Same as #469 and #437
Steps
Expected behavior
No error after search
Code
Logs
After making a local fix, I encountered another issue:
Then I simply searched for
.push(...
in@orama/orama/dist
and found a couple of places where this approach is used:To be honest, I didn't clone the project; I just looked into the
node_modules
It would be great if the fix could be released as soon as possible.
The text was updated successfully, but these errors were encountered: