Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diacritics support #75

Closed
sandstrom opened this issue Aug 2, 2022 · 3 comments
Closed

Diacritics support #75

sandstrom opened this issue Aug 2, 2022 · 3 comments
Labels
discussion

Comments

@sandstrom
Copy link

The search library Sifter (https://github.com/brianreavis/sifter.js/) has support for diacritics. Maybe Lyra could add something similar?

Their implementation is here: https://github.com/brianreavis/sifter.js/blob/master/lib/sifter.js#L444
@micheleriva
Copy link
Member

That sounds super interesting. Yes, we might be interested in supporting this!

micheleriva added a commit that referenced this issue Aug 4, 2022
@micheleriva
feat(lyra): removes diacritics to keep index smaller
e8396c3 
implements #75
@micheleriva
Copy link
Member

Implemented in e8396c3

@sandstrom
Copy link
Author

Nice! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sandstrom @mateonunez @micheleriva