search on all token during where searches #473
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discovered a bug while using search.where with multi token criterias. With the previous logic, only the first token was used for search.
My following pull request includes a test that was failing without this fix.
ex: defining these 4 documents:
And doing this search:
resulted in only 2 results. When tokenized the where criteria was converted to ["black", "matte"] and on line searchByWhereClause:479 only the first token was used resulting on only document 1 and 2 being returned.
Expected values: doc 1, 2 and 4.
This PR modifies the behavior to search on all tokens.