Feat/reduce serialized datastructure sizes #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current PR changes the internal property names for all the trees in Orama in order to reduce their impact on the final bundle size. Each tree node consists of several keys that get repeated multiple times, leading to a misuse of disk space, as these keys could easily be encoded into a single character.
This PR benefits have been tested against several datasets, showing a space-saving factor of about 5%.
Now, I am not sure if we really want to compromise code readability in favor of a 5% disk size saving. It's worth saying that we're editing tree algorithms that much.
@allevo and @raiindev, any thoughts about that?