Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Switch OramaClient condition + update dependency version #845

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

raiindev
Copy link
Contributor

A simple PR to:

  • Update the @oramacloud/client version inside the switch package
  • Fix the condition to check if an instance of OramaClient is passed due to an instanceof not being correct if the instance is created outside the project where the switch is imported.

@raiindev raiindev requested a review from micheleriva November 21, 2024 13:52
Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
orama-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 1:52pm

@raiindev raiindev merged commit 74511b6 into main Nov 22, 2024
3 checks passed
@raiindev raiindev deleted the feat/fix-switch-oramaclient-condition branch November 22, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants