fix: patchOperation

cmd/webhook.go

@@ -103,21 +103,18 @@ func mutationRequired(ignoredList []string, metadata *metav1.ObjectMeta) bool {
 func addEnvironnement(containers []corev1.Container, added []corev1.EnvVar, basePath string) (patch []patchOperation) {
 	// for each containers in the pod spec, append the env vars
 	for i := range containers {
-		// if the container has no env vars, initialize the env vars
-		if containers[i].Env == nil {
-			containers[i].Env = make([]corev1.EnvVar, 0)
-		}
+		var path string
 
-		// for each env var in the added env vars, append the env var to the container
-		for _, add := range added {
-			// Compute the path for the env var
-			path := basePath + "/" + fmt.Sprintf("%d/env", i)
-			patch = append(patch, patchOperation{
-				Op:    "add",
-				Path:  path,
-				Value: add,
-			})
+		path = basePath + "/" + fmt.Sprintf("%d/env", i)
+		if containers[i].Env != nil {
+			path = basePath + "/" + fmt.Sprintf("%d/env/-", i)
 		}
+
+		patch = append(patch, patchOperation{
+			Op:    "add",
+			Path:  path,
+			Value: added,
+		})
 	}
 
 	return patch

manifests/env-config.yaml

@@ -1,7 +1,7 @@
 env:
   - name: HTTP_PROXY
-    Value: http://10.1.2.3:3128
+    Value: "http://10.1.2.3:3128"
   - name: HTTPS_PROXY
-    Value: http://10.1.2.3:3128
+    Value: "http://10.1.2.3:3128"
   - name: NO_PROXY
-    Value: cluster.local,localhost,127.0.0.1
+    Value: "cluster.local,localhost,127.0.0.1"