Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add resource/datasource cloudavenue_network_dhcp #372

Merged
merged 3 commits into from
Jul 10, 2023

Conversation

azrod
Copy link
Member

@azrod azrod commented Jul 8, 2023

Description of your changes

Add resource and datasource for cloudavenue_network_dhcp

If you submit change in the provider code, please make sure to:

  • Write or modify examples in examples/ directory
  • Write or modify acceptance tests
  • Run make generate to ensure the doc was updated properly

How has this code been tested

TF_ACC=1 go test -v -count=1 -timeout 720m  -run TestAccDhcpDataSource ./internal/tests/network
=== RUN   TestAccDhcpDataSource
--- PASS: TestAccDhcpDataSource (90.31s)
PASS
ok      github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/tests/network     90.829s
TF_ACC=1 go test -v -count=1 -timeout 720m  -run TestAccDhcpResource ./internal/tests/network
=== RUN   TestAccDhcpResource
--- PASS: TestAccDhcpResource (164.40s)
PASS
ok      github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/tests/network     164.934s

@azrod azrod self-assigned this Jul 8, 2023
@azrod azrod linked an issue Jul 8, 2023 that may be closed by this pull request
@crown-app
Copy link

crown-app bot commented Jul 8, 2023

Thank you for your contribution, but this PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR.
Note this PR might be rejected due to its size.

@azrod azrod force-pushed the 348-new-resource-add-cloudavenue_network_dhcp branch from ae132e1 to a969714 Compare July 8, 2023 09:30
@azrod azrod force-pushed the 348-new-resource-add-cloudavenue_network_dhcp branch from a969714 to d32ed7a Compare July 8, 2023 09:31
@azrod azrod force-pushed the 348-new-resource-add-cloudavenue_network_dhcp branch from d32ed7a to e4676f7 Compare July 8, 2023 09:41
@azrod azrod requested a review from dmicheneau July 8, 2023 09:41
@azrod azrod linked an issue Jul 8, 2023 that may be closed by this pull request
@azrod azrod marked this pull request as ready for review July 8, 2023 09:42
.changelog/349.txt Outdated Show resolved Hide resolved
internal/client/org.go Show resolved Hide resolved
Co-authored-by: david micheneau <47741512+dmicheneau@users.noreply.github.com>
@crown-app crown-app bot added the Chore label Jul 10, 2023
@dmicheneau dmicheneau merged commit a64c48c into main Jul 10, 2023
@dmicheneau dmicheneau deleted the 348-new-resource-add-cloudavenue_network_dhcp branch July 10, 2023 15:36
gaetanars pushed a commit that referenced this pull request Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Data Source]: Add cloudavenue_network_dhcp [New Resource]: Add cloudavenue_network_dhcp
2 participants