Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix nat rule type no_snat and no_dnat #820

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

dmicheneau
Copy link
Member

@dmicheneau dmicheneau commented Nov 14, 2024

Description of your changes

If you submit change in the provider code, please make sure to:

  • Write or modify examples in examples/ directory
  • Write or modify acceptance tests
  • Run make generate to ensure the doc was updated properly

How has this code been tested

Resource
--- PASS: TestAccEdgeGatewayNATRuleResource (1238.85s)
PASS
ok      github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/testsacc  1239.402s

Datasource
--- PASS: TestAccEdgeGatewayNATRuleDataSource (331.23s)
PASS
ok      github.com/orange-cloudavenue/terraform-provider-cloudavenue/internal/testsacc  331.727s

@dmicheneau dmicheneau requested a review from a team as a code owner November 14, 2024 21:45
@dmicheneau dmicheneau linked an issue Nov 14, 2024 that may be closed by this pull request
@dmicheneau dmicheneau self-assigned this Nov 14, 2024
@dmicheneau dmicheneau force-pushed the 815-bug-unable-to-create-no_snat branch from 1d24b65 to 3471f25 Compare November 15, 2024 08:16
Copy link
Member

@azrod azrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great testacc refacto 👍 👍

There are still some points to correct :

internal/provider/edgegw/nat_rule_resource.go Outdated Show resolved Hide resolved
internal/testsacc/edgegw_nat_rule_datasource_test.go Outdated Show resolved Hide resolved
internal/testsacc/edgegw_nat_rule_resource_test.go Outdated Show resolved Hide resolved
internal/testsacc/edgegw_nat_rule_resource_test.go Outdated Show resolved Hide resolved
internal/testsacc/edgegw_nat_rule_resource_test.go Outdated Show resolved Hide resolved
@dmicheneau dmicheneau changed the title chore: fix nul pointer when datasource was not found chore: fix nat rule type no_snat and no_dnat Nov 15, 2024
@dmicheneau dmicheneau force-pushed the 815-bug-unable-to-create-no_snat branch 4 times, most recently from 8a41544 to 4bc8255 Compare November 15, 2024 15:28
terraform-registry-manifest.json Outdated Show resolved Hide resolved
internal/testsacc/edgegw_nat_rule_resource_test.go Outdated Show resolved Hide resolved
@dmicheneau dmicheneau force-pushed the 815-bug-unable-to-create-no_snat branch 3 times, most recently from 696c0ab to 600f299 Compare November 19, 2024 10:57
@dmicheneau dmicheneau force-pushed the 815-bug-unable-to-create-no_snat branch from 600f299 to 39fc7ee Compare November 19, 2024 14:14
@dmicheneau dmicheneau added the bug Something isn't working label Nov 19, 2024
@dmicheneau dmicheneau merged commit 2f4acb6 into main Nov 19, 2024
7 checks passed
@dmicheneau dmicheneau deleted the 815-bug-unable-to-create-no_snat branch November 19, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Unable to create NO_SNAT
2 participants