-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix nat rule type no_snat and no_dnat #820
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmicheneau
force-pushed
the
815-bug-unable-to-create-no_snat
branch
from
November 15, 2024 08:16
1d24b65
to
3471f25
Compare
azrod
requested changes
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great testacc refacto 👍 👍
There are still some points to correct :
- Missing a changelog.
- Missing a testacc result in the PR description.
- Fix your commit message and PR title.
- Missing testacc entry in global setting
dmicheneau
changed the title
chore: fix nul pointer when datasource was not found
chore: fix nat rule type no_snat and no_dnat
Nov 15, 2024
dmicheneau
force-pushed
the
815-bug-unable-to-create-no_snat
branch
4 times, most recently
from
November 15, 2024 15:28
8a41544
to
4bc8255
Compare
azrod
requested changes
Nov 15, 2024
dmicheneau
force-pushed
the
815-bug-unable-to-create-no_snat
branch
3 times, most recently
from
November 19, 2024 10:57
696c0ab
to
600f299
Compare
dmicheneau
force-pushed
the
815-bug-unable-to-create-no_snat
branch
from
November 19, 2024 14:14
600f299
to
39fc7ee
Compare
azrod
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
If you submit change in the provider code, please make sure to:
examples/
directorymake generate
to ensure the doc was updated properlyHow has this code been tested