refactor: deduplicate repeat parsers alloc logic #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deduplicates the results allocation logic used in MPC_TYPE_MANY and MPC_TYPE_MANY1 on a `grow_results` function. This will aid in implementing new repeat parser types. A new one is neeeded for `sepby1` as discussed on orangeduck#165 (comment).
|
Perhaps you can rename this to |
steve-chavez
added a commit
to steve-chavez/mpc
that referenced
this pull request
Aug 21, 2023
To not cause naming conflicts as mentioned on orangeduck#166 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deduplicates the results allocation logic used in MPC_TYPE_MANY and MPC_TYPE_MANY1 on a
grow_resultsfunction.This will aid in implementing new repeat parser types. A new one is neeeded for
sepby1as discussed on #165 (comment).