This repository has been archived by the owner on Apr 7, 2024. It is now read-only.
feat: Add 'MemoryStore' #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uanid
requested review from
shizhMSFT,
Wwwsylvia and
TerryHowe
as code owners
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #92 +/- ##
==========================================
+ Coverage 76.08% 76.86% +0.78%
==========================================
Files 7 8 +1
Lines 414 428 +14
==========================================
+ Hits 315 329 +14
Misses 77 77
Partials 22 22
|
Wwwsylvia
suggested changes
Sep 5, 2023
Wwwsylvia
reviewed
Sep 5, 2023
Signed-off-by: Uanid <uanid@outlook.com>
Signed-off-by: Uanid <uanid@outlook.com>
Signed-off-by: Uanid <uanid@outlook.com>
|
@shizhMSFT Could you take a look as well? |
shizhMSFT
approved these changes
Sep 8, 2023
inmemory_store.go
Outdated
| ) | ||
|
|
||
| // InMemoryStore is a store that keeps credentials in memory. | ||
| type InMemoryStore struct { |
There was a problem hiding this comment.
Will it be better to name it MemoryStore instead of InMemoryStore?
There was a problem hiding this comment.
That might be a good name. Changed it to MemoryStore.
Co-authored-by: Lixia (Sylvia) Lei <lixlei@microsoft.com> Signed-off-by: Minuk Song <uanid@outlook.com>
Signed-off-by: Uanid <uanid@outlook.com>
Wwwsylvia
reviewed
Sep 11, 2023
Signed-off-by: Uanid <uanid@outlook.com>
|
Merged. Thank you @uanid again for contributing this! |
Wwwsylvia
pushed a commit
to oras-project/oras-go
that referenced
this pull request
Sep 20, 2023
Features: - Add `MemoryStore` I submitted a pull request for MemoryStore to `oras-credentials-go` a week ago. However, the repository has since been deprecated. I've created an identical PR to [this one](oras-project/oras-credentials-go#92). Reference Issue: [Here](oras-project/oras-credentials-go#89) Signed-off-by: Uanid <uanid@outlook.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features:
MemoryStoreReference Issue: #89