-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add reference details to registry errors #1152
Conversation
Include values of the artifact and or related context in the errors - This is related to oras-project/oras#1152. See the oras-project/oras#1152 to see the updates to output of errors. Signed-off-by: Sajay Antony <sajaya@microsoft.com>
Signed-off-by: Sajay Antony <sajaya@microsoft.com>
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #1152 +/- ##
==========================================
- Coverage 79.47% 79.45% -0.02%
==========================================
Files 65 65
Lines 3493 3495 +2
==========================================
+ Hits 2776 2777 +1
- Misses 506 507 +1
Partials 211 211
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks @shizhMSFT @qweeah |
Any possibility to get a develop or branch named container build here? I just ran into the (previous) ambiguous error and this would be very helpful! In the meantime I'll do a custom build, but would be great to have this tag ready to go. |
@vsoch You may try |
@qweeah it's for an operator sidecar that (ideally) doesn't require minimal setup. I am suggesting building a latest tag (that reflects the current main branch) so users always have access to the latest (and not the last release, which can be months old). |
Agree, adding a container can be a good start. The container can be built when merging PR into main branch Not sure about the tag naming, maybe main is better than latest? @FeynmanZhou |
Perhaps a develop or main (branch) tag would make sense? It should indicate “this is not a production container there might be bugs use at your own risk!” |
@qweeah is there an issue for pushing an updated container on merge or maybe daily? |
I will create one. |
@vsoch Are you expecting an ORAS image with a |
What this PR does / why we need it:
The errors from the oras CLI does not show the actual value that was provided.
The following PR updates the erros to include the actual user provided reference here -