-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: make error of non-existed source OCI layout more readable #1176
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #1176 +/- ##
==========================================
- Coverage 80.05% 79.87% -0.18%
==========================================
Files 65 65
Lines 3564 3572 +8
==========================================
Hits 2853 2853
- Misses 495 503 +8
Partials 216 216
|
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…s-project#1176) Signed-off-by: Billy Zha <jinzha1@microsoft.com> Co-authored-by: Sajay Antony <sajaya@microsoft.com> Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
What this PR does / why we need it:
This PR improves error message for OCI layout.
If the provided path doesn't exist
If the provided path is a file but not a tarfile
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1156
Please check the following list: