Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid overflow in progress bar percentage #1178

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

qweeah
Copy link
Contributor

@qweeah qweeah commented Nov 7, 2023

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1175.

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1178 (78e7ba5) into main (92f9c8b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main    #1178      +/-   ##
==========================================
+ Coverage   80.02%   80.03%   +0.01%     
==========================================
  Files          65       65              
  Lines        3560     3562       +2     
==========================================
+ Hits         2849     2851       +2     
  Misses        495      495              
  Partials      216      216              
Files Coverage Δ
cmd/oras/internal/display/progress/status.go 95.16% <100.00%> (+0.07%) ⬆️

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit 5e62c14 into oras-project:main Nov 8, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NaN shown in the progress bar with zero-length blob
3 participants