Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use trust-dns #43

Merged
merged 3 commits into from
Sep 28, 2022
Merged

Allow to use trust-dns #43

merged 3 commits into from
Sep 28, 2022

Conversation

astoycos
Copy link
Contributor

@astoycos astoycos commented Sep 8, 2022

Add options to oci-distrobution to use
non local DNS, mainly for when
running embedded in a docker container.

@astoycos
Copy link
Contributor Author

astoycos commented Sep 9, 2022

I don't think the failing CI is part of this :)

@astoycos
Copy link
Contributor Author

astoycos commented Sep 9, 2022

If I get a chance I'll investigate further

@thomastaylor312
Copy link
Contributor

I don't think the cargo deny is related, but the build test might be. I'm a bit busy this week but will try to get to debugging it a bit

Add options to oci-distrobution to use
non local DNS, mainly for when
running embedded in a docker container.

Signed-off-by: Andrew Stoycos <astoycos@redhat.com>
@astoycos
Copy link
Contributor Author

Ran this all locally and things were working, pushed again to re-trigger actions

@astoycos
Copy link
Contributor Author

failures:

---- client::test::test_platform_resolution stdout ----
thread 'client::test::test_platform_resolution' panicked at 'Couldn't pull manifest: RequestError(reqwest::Error { kind: Request, url: Url { scheme: "https", cannot_be_a_base: false, username: "", password: None, host: Some(Domain("auth.docker.io")), port: None, path: "/token", query: Some("scope=repository%3Alibrary%2Fhello-world%3Apull&service=registry.docker.io"), fragment: None }, source: hyper::Error(IncompleteMessage) })', src/client.rs:2227:14
error: test failed, to rerun pass '--lib'

Was the error in the unit tests the first time

Add the `Unicode-DFS-2016` license to the list of allowed licenses. This
is used by the `unicode-ident` crate.

Signed-off-by: Flavio Castelli <fcastelli@suse.com>
Address some warnings raised by clippy

Signed-off-by: Flavio Castelli <fcastelli@suse.com>
@flavio
Copy link
Contributor

flavio commented Sep 28, 2022

@astoycos Sorry for the late response. I've looked into the failures and fixed them with some commits.

I'll let the test run and, if everything is green, I'll merge the PR

@flavio
Copy link
Contributor

flavio commented Sep 28, 2022

All green!

@flavio flavio merged commit b53c055 into oras-project:main Sep 28, 2022
@astoycos
Copy link
Contributor Author

Thanks @flavio!

thomastaylor312 pushed a commit that referenced this pull request Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants