Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix for rooms with only one member #5

Merged
merged 1 commit into from
Nov 8, 2018

Conversation

heuri
Copy link
Contributor

@heuri heuri commented Nov 7, 2018

Rooms with only one member are having a different format in the json object and would result in an error:

# hipmost -v public import "site" 'Company':"site"
site
Parsing rooms for Hipchat and Mattermost...
Hipchat room is:               site
Mattermost team & channel are: Company:site
Successfully parsed rooms

Opening /root/migrate/site.jsonl for writing...
Writing version header...
Writing team info...
Writing channel info...
Writing room members...
Traceback (most recent call last):
        14: from /usr/local/rvm/gems/ruby-2.5.1/bin/ruby_executable_hooks:24:in `<main>'
        13: from /usr/local/rvm/gems/ruby-2.5.1/bin/ruby_executable_hooks:24:in `eval'
        12: from /usr/local/rvm/gems/ruby-2.5.1/bin/hipmost:23:in `<main>'
        11: from /usr/local/rvm/gems/ruby-2.5.1/bin/hipmost:23:in `load'
        10: from /usr/local/rvm/gems/ruby-2.5.1/gems/hipmost-1.0/exe/hipmost:48:in `<top (required)>'
         9: from /usr/local/rvm/gems/ruby-2.5.1/gems/hipmost-1.0/lib/hipmost.rb:14:in `run'
         8: from /usr/local/rvm/gems/ruby-2.5.1/gems/hipmost-1.0/lib/hipmost/cmds/room.rb:23:in `run'
         7: from /usr/local/rvm/gems/ruby-2.5.1/gems/hipmost-1.0/lib/hipmost/cmds/room.rb:47:in `import'
         6: from /usr/local/rvm/gems/ruby-2.5.1/gems/hipmost-1.0/lib/hipmost/cmds/room.rb:54:in `save'
         5: from /usr/local/rvm/gems/ruby-2.5.1/gems/hipmost-1.0/lib/hipmost/cmds/room.rb:54:in `open'
         4: from /usr/local/rvm/gems/ruby-2.5.1/gems/hipmost-1.0/lib/hipmost/cmds/room.rb:64:in `block in save'
         3: from /usr/local/rvm/gems/ruby-2.5.1/gems/hipmost-1.0/lib/hipmost/cmds/room.rb:64:in `each'
         2: from /usr/local/rvm/gems/ruby-2.5.1/gems/hipmost-1.0/lib/hipmost/cmds/room.rb:65:in `block (2 levels) in save'
         1: from /usr/local/rvm/gems/ruby-2.5.1/gems/hipmost-1.0/lib/hipmost/cmds/room.rb:65:in `each'
/usr/local/rvm/gems/ruby-2.5.1/gems/hipmost-1.0/lib/hipmost/cmds/room.rb:66:in `block (3 levels) in save': undefined method `to_jsonl' for nil:NilClass (NoMethodError)

data/rooms.json

 {
    "Room": {
      "created": "2018-06-07T14:57:26+00:00",
      "guest_access_url": null,
      "id": 12,
      "is_archived": false,
      "members": [
        1,
        2,
        3,
        4,
        6
      ],
      "name": "dev",
      "owner": 6,
      "participants": [],
      "privacy": "private",
      "room_admins": [
        6
      ],
      "topic": ""
    }
  },

"Room": {
        "created": "2018-10-06T12:48:40+00:00",
        "guest_access_url": null,
        "id": 14,
        "is_archived": false,
        "members": [
          {
            "id": 1,
            "mention_name": "heuri",
            "name": "heuri",
            "room_roles": [
              "room_member",
              "room_admin"
            ],
            "version": "PCBLOVIS"
          }
        ],
        "name": "Vertrieb",
        "owner": 1,
        "participants": [],
        "privacy": "public",
        "room_admins": [
          1
        ],
        "topic": ""
      }

Rooms with only one member are having a different format in the json object and would result in an error "undefined method `to_jsonl' for nil:NilClass (NoMethodError)":

```
"Room": {
        "created": "2018-10-06T12:48:40+00:00",
        "guest_access_url": null,
        "id": 14,
        "is_archived": false,
        "members": [
          {
            "id": 1,
            "mention_name": "heuri",
            "name": "heuri",
            "room_roles": [
              "room_member",
              "room_admin"
            ],
            "version": "PCBLOVIS"
          }
        ],
        "name": "Vertrieb",
        "owner": 1,
        "participants": [],
        "privacy": "public",
        "room_admins": [
          1
        ],
        "topic": ""
      }
```
@gabrielrios gabrielrios merged commit ee1c09d into orbitalimpact:master Nov 8, 2018
@gabrielrios
Copy link
Contributor

Great, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants