Fixing dep tree

[daviddias]

Started doing things for orbitdb-archive/orbit-web#9

It seems that is really embed in the concept of Orbit that PubSub messages are passed as strings and not as Buffers.

 1) Orbit send sends a message to a channel:
     TypeError: "string" must be a string, Buffer, or ArrayBuffer
      at Function.byteLength (buffer.js:477:11)
      at Promise (node_modules/ipfs-post/src/Post.js:44:51)
      at Promise (<anonymous>)
      at Function.create (node_modules/ipfs-post/src/Post.js:27:12)
      at Orbit._postMessage (src/Orbit.js:373:17)
      at getUser.then.then.then (src/Orbit.js:165:28)
      at <anonymous>

I fixed one of these assumptions, but now found that there is an assumption in another dependency. Before I follow this 🐇, I want to make sure it is cool to refactor this things, I might have to change a lot of nits to make it all work and end up with a big refactor.

[daviddias]

@haadcode you were truncating every message. Is there a reason for that in Orbit?

[haadcode]

Haha, yeah! :D That was a quick fix long time ago when some random tester on orbit started flooding with very long messages. It's not a great place to fix that problem but rather should be fixed on the lower levels (orbit-db side). If you can, leave it as it is now (truncate the message, do use buffers if you're changing them) and we'll handle that in the data structures or in orbit-db eventually. Sound good?

[daviddias]

That makes sense. The message format should be a dag so that it can growth to any length (or at least block large messages at the user interaction level).

[haadcode]

Hey @diasdavid and thank you for the PR! Awesome that you're willing to look into this <3 I won't have much bandwidth myself to work on it but I'll try to help you as much as possible.

Re. the string vs. Buffer assumption, iirc, I assumed strings way back in the day before we had pubsub. As far as I know there's no reason to continue on that assumption, but rather as you propose, use Buffers throughout the code. So if you're up for it, go ahead and change them.

[latenssi]

Closing as this deviates from current master and is quite old