This repository has been archived by the owner on Aug 22, 2022. It is now read-only.
Npm policy: Use orbitdb.maintainer field #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `maintainer` field turns out to be reserved, and not public, and it does not match the output of `npm info`. Npm does not offer a native way in the package.json to show who the maintainers are, bizarrely. In order to sidestep this, I propose here adding an orbitdb.maintainer field to our package.jsons. Using an "orbitdb" key allows us to future-proof this in case we want to use other metadata in the future in our npm manifests.
RichardLitt
added a commit
to orbitdb-archive/crdts
that referenced
this pull request
Mar 27, 2019
In keeping with orbitdb-archive/welcome#55, I add an orbitdb field here. I also suggest @shamb0t as an extra maintainer, as she is already a contributor here. When this is merged, she should be added.
|
I need to update this. At the moment, I think it is a bit behind what we currently should/ought to use. I'll come back to this. |
|
👍 LGTM and this should also be in the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
maintainerfield turns out to be reserved, and not public, and it does not match the output ofnpm info. Npm does not offer a native way in the package.json to show who the maintainers are, bizarrely. In order to sidestep this, I propose here adding an orbitdb.maintainer field to our package.jsons. Using an "orbitdb" key allows us to future-proof this in case we want to use other metadata in the future in our npm manifests.