New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix off by one error #9

Draft

n7275 wants to merge 1 commit into master from fixOffByOne

Member

n7275 commented Nov 17, 2024

needs to be rebuilt before merging


          fix off by one error and rebuild

af04e3d

n7275 force-pushed the fixOffByOne branch from 930d80e to af04e3d Compare

November 18, 2024 05:22

n7275 marked this pull request as draft

November 18, 2024 06:44

n7275 mentioned this pull request

Frame count should run from 1-50 not 0-49 orbiternassp/NASSP#1313

Draft

Member

thewonderidiot commented Nov 23, 2024

This logic is super janky haha: https://github.com/orbiternassp/telemetryClient/pull/9/files#diff-266251b89e8eaab9c238260c3eb2aeca5779263b0c48b7fd254625798ee85e01L1923
I think it's now incorrect due to frame number change. Frame 1 should be framect=0, frame 2 should be framect=1, etc... right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet