JSON API 1.0 compliance #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSON-API is explicit about the name of the `id` field to be used in resource objects.
The jsonpatch extension is now an experimental part of JSON API. This needs to be revisited.
This was referenced Jun 19, 2015
Closed
|
❤️ -- Thanks for taking it all the way. The journey to Nantucket became a nightmare of Boston traffic... I was supposed to have my evening, and instead barely had dinner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings Orbit into compliance with v1.0 of the JSON API spec.
Most of this work is related to the
JSONAPISourceandJSONAPISerializer.Also, the
JSONAPIPatchSourcehas been temporarily removed now that thejsonpatchextension has been made an experimental part of the JSON API spec. Work can be expected to continue on both the extension and the source (although time will tell whether it remains part of the OrbitCommon lib).Note that further work is planned related to JSON API, which will be discussed in separate issues.