Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile to CommonJS with support for npm #213

Merged
merged 1 commit into from
Aug 18, 2016
Merged

Compile to CommonJS with support for npm #213

merged 1 commit into from
Aug 18, 2016

Conversation

theodorton
Copy link
Contributor

Proof-of-concept:

# In your local copy of orbit
$ broccoli build build
$ cd build/npm
$ npm link

# In your node project folder
$ npm link orbit.js
// This should now be possible from within your node project
var Orbit = require('orbit.js');
var OC = require('orbit.js/orbit-common');

@theodorton
Copy link
Contributor Author

Related to #117 and #162

@dgeb
Copy link
Member

dgeb commented Oct 3, 2015

Great! Thanks @theodorton 👍

I'll aim to include commonjs output in the next release (after the rethink branch is merged).

@jimmybaker
Copy link

👍 Would love this.

@SmuliS
Copy link
Contributor

SmuliS commented Nov 3, 2015

👍

@leobalter
Copy link

@dgeb, I'm sorry if this sounds as another +1 comment, but it would be great if we could already get Orbit from npm, and you could push a new version for the rethink branch.

I'm currently working on a project where I'm transpiling es6 => commonjs modules with webpack and the changes on this PR would be great for a clean use.

If it counts too, Orbit, including the schema features and JSON-API compatibility, is the exactly tool I'm looking for this app.

@dgeb
Copy link
Member

dgeb commented Nov 13, 2015

@leobalter et al - I hear the +1s and enthusiasm and am working feverishly on the rethink branch. There are a huge number of changes (mostly simplifications) in this branch and I'm looking forward to your feedback. I will push to npm once it's stable and green as a new 0.7 beta release.

@leobalter
Copy link

Thanks, @dgeb! I've had the chance to talk to @gnarf and then I understand the huge changes about to come. Until there, ping me anytime if you want to me try any npm beta releases from the rethink branch.

@dgeb
Copy link
Member

dgeb commented Nov 14, 2015

Great - thanks @leobalter!

@damon-kreft
Copy link

Sorry @dgeb, another +1 through sheer selfish desperation even though I know you're aware and working hard 😛

@dgeb dgeb merged commit 0a372fe into orbitjs:master Aug 18, 2016
@dgeb
Copy link
Member

dgeb commented Aug 18, 2016

Ok, prepping to finally get a build out (on npm-only this time). I was able to merge this CommonJS work into the updated Brocfile. Thanks again @theodorton!

@theodorton
Copy link
Contributor Author

Yay 🎉

Looking forward to the release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants