Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce autoValidate setting for RecordCache and RecordSource #915

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

dgeb
Copy link
Member

@dgeb dgeb commented Jan 21, 2022

This setting mirrors autoUpgrade and autoActivate in that if it is left undefined it should be treated as true.

RecordCache and RecordSource use this to determine whether to build validators if none are provided.

SyncRecordCache and AsyncRecordCache also use this option to control whether a schema validation processor is included by default.

This will provide more fine-tuned control over whether validators are built and used by a source / cache than checking Orbit.debug.

Closes #903

Note: This is considered a breaking change because Orbit.debug is no longer used to implicitly set autoValidate.

This setting mirrors `autoUpgrade` and `autoActivate` in that if it is left `undefined` it should be treated as `true`.

`RecordCache` and `RecordSource` use this to determine whether to build validators if none are provided.

`SyncRecordCache` and `AsyncRecordCache` also use this option to control whether a schema validation processor is included by default.

This will provide more fine-tuned control over whether validators are built and used by a source / cache than checking `Orbit.debug`.
@dgeb dgeb added breaking breaking change enhancement labels Jan 21, 2022
@dgeb dgeb merged commit b87d5ce into main Jan 21, 2022
@dgeb dgeb deleted the build-validators branch January 21, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce autoValidate setting for RecordSource and RecordCache
1 participant