Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve robustness of isNode check #937

Merged
merged 1 commit into from
Mar 6, 2022
Merged

Improve robustness of isNode check #937

merged 1 commit into from
Mar 6, 2022

Conversation

dgeb
Copy link
Member

@dgeb dgeb commented Mar 6, 2022

Use optional chaining to handle cases in which the global process is null (because typeof null === 'object').

Fixes #933

Use optional chaining to handle cases in which the global `process` is `null` (because `typeof null === 'object'`).

Fixes #933
@dgeb dgeb added the bug label Mar 6, 2022
@dgeb dgeb merged commit 4d86b18 into main Mar 6, 2022
@dgeb dgeb deleted the fix-933 branch March 6, 2022 20:12
@dgeb dgeb mentioned this pull request Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not create MemorySource
1 participant