Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "validatorFor" to RecordTransformBuffer #984

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

enspandi
Copy link
Contributor

As otherwise it will ignore custom validators.


I also tried passing in a custom transformBuffer to the indexeddb source settings as mentioned in #868 - but it is not passed forward to the indexeddb cache settings....

As otherwise it will ignore custom validators.
@enspandi
Copy link
Contributor Author

enspandi commented Jan 26, 2023

@dgeb I should note that custom validator works with Indexed db source if

settings.defaultTransformOptions = { useBuffer: true };

is not set.

It seems to run the validation process of the indexeddb cache class which uses the correct validatorFor function. But in case of useBuffer: true it will create a new transform buffer class that does not have it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant