Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with inline comment #168

Merged
merged 4 commits into from
Dec 13, 2022
Merged

Fix bug with inline comment #168

merged 4 commits into from
Dec 13, 2022

Conversation

BOOMeranGG
Copy link
Collaborator

@BOOMeranGG BOOMeranGG commented Dec 8, 2022 •
edited
Loading

Fix #167

@BOOMeranGG BOOMeranGG changed the title Rewrite takeBeforeComment and trimComment functions Fix bug with inline comment Dec 8, 2022
@BOOMeranGG BOOMeranGG force-pushed the fix-symbols-in-inline-comment branch from 7967559 to b7fd07a Compare December 8, 2022 21:19
@NightEule5 NightEule5 requested a review from orchestr7 December 8, 2022 22:01
@BOOMeranGG
Copy link
Collaborator Author

@akuleshov7 Previous time one check failed. Is something wrong?

@orchestr7
Copy link
Owner

@akuleshov7 Previous time one check failed. Is something wrong?
approved run, let me check. Have you run ./gradlew diktatFixAll or ./gradlew detekt tasks?

@BOOMeranGG
Copy link
Collaborator Author

Have you run ./gradlew diktatFixAll or ./gradlew detekt tasks?
Yes, I have. It's all right. Let's merge?

@orchestr7 orchestr7 merged commit d0a121d into orchestr7:main Dec 13, 2022
@orchestr7
Copy link
Owner

Have you run ./gradlew diktatFixAll or ./gradlew detekt tasks?
Yes, I have. It's all right. Let's merge?

Great, thank you so much for this fix!

@BOOMeranGG BOOMeranGG deleted the fix-symbols-in-inline-comment branch December 13, 2022 15:18
@BOOMeranGG BOOMeranGG mentioned this pull request Dec 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NightEule5 NightEule5 NightEule5 left review comments

@orchestr7 orchestr7 orchestr7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug with " symbol in inline comment
3 participants
@BOOMeranGG @orchestr7 @NightEule5