Adding the support for Char #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What's done: - conversion from string to char - enabling some old tests - still we need unicode conversion
### What's done: - conversion from a literal string to char - enabling some old tests - still we need unicode conversion and fixes for literal strings
### What's done: - conversion from a literal string to char - enabling some old tests - still we need unicode conversion and fixes for literal strings
### What's done: - conversion from a literal string to char - enabling some old tests - still we need unicode conversion and fixes for literal strings
orchestr7
commented
Jan 5, 2023
| override fun decodeChar(): Char = invalidType("Char", "String") | ||
| override fun decodeChar(): Char { | ||
| val keyValue = decodeKeyValue() | ||
| return when (val value = keyValue.value) { |
There was a problem hiding this comment.
We will give users a possibility to decode Char from integer or from a literal
There was a problem hiding this comment.
char1 = 156
char2 = '5'
TOML standard does not support Char, but we will have it out of the box
|
@aSemy @nulls @NightEule5 @BOOMeranGG I hope you don't mind if I will merge it without review, anyway we will polish it later... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's done: