Override Illuminate\Foundation\Bootstrap\HandleExceptions (#92)

* Override `Illuminate\Foundation\Bootstrap\HandleExceptions` Framework PR: laravel/framework#45299 Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> * wip * wip Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> * wip Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> * wip Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> * wip Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> * wip Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> * wip Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> * wip Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com> Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
orchestral · Dec 14, 2022 · 51866b3 · 51866b3
1 parent dda9c32
commit 51866b3
Show file tree

Hide file tree

Showing 4 changed files with 84 additions and 1 deletion.
diff --git a/phpunit.xml b/phpunit.xml
@@ -34,5 +34,7 @@
     <php>
         <server name="APP_ENV" value="testing"/>
         <server name="APP_KEY" value="AckfSECXIvnK5r28GVIWUAxmbBSjTsmF"/>
+        <server name="LOG_DEPRECATIONS_CHANNEL" value="stderr"/>
+        <server name="SEND_DEPRECATED_NOTICES_TO_RAY" value="(true)"/>
     </php>
 </phpunit>
diff --git a/src/Bootstrap/HandleExceptions.php b/src/Bootstrap/HandleExceptions.php
@@ -0,0 +1,51 @@
+<?php
+
+namespace Orchestra\Testbench\Bootstrap;
+
+use ErrorException;
+use Exception;
+use Illuminate\Log\LogManager;
+
+final class HandleExceptions extends \Illuminate\Foundation\Bootstrap\HandleExceptions
+{
+    /**
+     * Reports a deprecation to the "deprecations" logger.
+     *
+     * @param  string  $message
+     * @param  string  $file
+     * @param  int  $line
+     * @param  int  $level
+     * @return void
+     */
+    public function handleDeprecationError($message, $file, $line, $level = E_DEPRECATED)
+    {
+        if (! class_exists(LogManager::class)
+            || ! static::$app->hasBeenBootstrapped()
+        ) {
+            return;
+        }
+
+        try {
+            $logger = static::$app->make(LogManager::class);
+        } catch (Exception $e) {
+            return;
+        }
+
+        $this->ensureDeprecationLoggerIsConfigured();
+
+        /** @phpstan-ignore-next-line */
+        $options = static::$app['config']->get('logging.deprecations') ?? [];
+
+        with($logger->channel('deprecations'), function ($log) use ($message, $file, $line, $level, $options) {
+            $error = new ErrorException($message, 0, $level, $file, $line);
+
+            if ($options['trace'] ?? false) {
+                $log->warning((string) $error);
+            } else {
+                $log->warning(sprintf('%s in %s on line %s',
+                    $message, $file, $line
+                ));
+            }
+        });
+    }
+}
diff --git a/src/Concerns/CreatesApplication.php b/src/Concerns/CreatesApplication.php
@@ -9,6 +9,7 @@
 use Illuminate\Support\Facades\Facade;
 use Illuminate\Support\Facades\RateLimiter;
 use Orchestra\Testbench\Foundation\PackageManifest;
+use PHPUnit\Framework\TestCase as PHPUnitTestCase;
 
 /**
  * @property bool|null $enablesPackageDiscoveries
@@ -319,7 +320,12 @@ protected function resolveApplicationExceptionHandler($app)
      */
     protected function resolveApplicationBootstrappers($app)
     {
-        $app->make('Illuminate\Foundation\Bootstrap\HandleExceptions')->bootstrap($app);
+        $app->make(
+            $this instanceof PHPUnitTestCase
+                ? 'Orchestra\Testbench\Bootstrap\HandleExceptions'
+                : 'Illuminate\Foundation\Bootstrap\HandleExceptions'
+        )->bootstrap($app);
+
         $app->make('Illuminate\Foundation\Bootstrap\RegisterFacades')->bootstrap($app);
         $app->make('Illuminate\Foundation\Bootstrap\SetRequestForConsole')->bootstrap($app);
         $app->make('Illuminate\Foundation\Bootstrap\RegisterProviders')->bootstrap($app);

diff --git a/tests/PhpDeprecationsTest.php b/tests/PhpDeprecationsTest.php
@@ -0,0 +1,24 @@
+<?php
+
+namespace Orchestra\Testbench\Tests;
+
+use Illuminate\Support\Facades\Log;
+use Orchestra\Testbench\TestCase;
+
+class PhpDeprecationsTest extends TestCase
+{
+    /** @test */
+    public function handle_php81_deprecations()
+    {
+        Log::shouldReceive('channel')
+            ->once()->with('deprecations')
+            ->andReturnSelf()
+            ->shouldReceive('warning')
+            ->once()
+            ->withArgs(function ($message) {
+                return strpos($message, 'zzz in') !== false;
+            });
+
+        trigger_error('zzz', E_USER_DEPRECATED);
+    }
+}