Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TPP-799: Fix Atlassian JIRA plugin vuln (Snyk, @mui/utils) #289

Closed
wants to merge 2 commits into from

Conversation

wtfiwtz
Copy link
Contributor

@wtfiwtz wtfiwtz commented Jun 12, 2024

What this PR does, and why

Notification from Atlassian regarding JIRA plugin - vulnerability detected (by Snyk) in @mui/utils
Includes a minor release upgrade to Storybook 7.6 to .19

One outstanding vulnerability (no available fix yet)

ip  *
Severity: high
ip SSRF improper categorization in isPublic - https://github.com/advisories/GHSA-2p57-rm9w-gvfp
fix available via `npm audit fix --force`
Will install storybook@8.1.7, which is a breaking change
node_modules/ip
  @storybook/core-server  <=8.1.5 || 8.2.0-alpha.0 - 8.2.0-alpha.5
  Depends on vulnerable versions of ip
  node_modules/@storybook/core-server
    @storybook/cli  <=0.0.0-pr-27522-sha-b32386a1 || 6.5.17-alpha.0 - 8.1.5 || 8.2.0-alpha.0 - 8.2.0-alpha.5
    Depends on vulnerable versions of @storybook/core-server
    node_modules/@storybook/cli
      storybook  <=0.0.0-pr-28144-sha-88097b55 || 6.5.17-alpha.0 - 8.1.5 || 8.2.0-alpha.0 - 8.2.0-alpha.5
      Depends on vulnerable versions of @storybook/cli
      node_modules/storybook

4 high severity vulnerabilities

@wtfiwtz wtfiwtz self-assigned this Jun 12, 2024
"@mui/types": "^7.2.14",
"@mui/utils": "^5.15.14",
"@mui/utils": "^5.15.20",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not 100% this goes far enough? The snyk vuln report says it needs v6 at least.

https://security.snyk.io/vuln/SNYK-JS-MUIUTILS-7231125

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems it might be worth a wait-and-see for now... since it may be a false positive on Snyk's side?
mui/material-ui#42607

@@ -46,9 +46,9 @@
"dependencies": {
"@emotion/react": "^11.11.4",
"@emotion/styled": "^11.11.5",
"@mui/icons-material": "^5.15.18",
"@mui/material": "^5.15.18",
"@mui/x-date-pickers": "^7.5.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be we can upgrade the @mui libraries to 6.0.0-alpha.9

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like that fails in the CI pipeline 😭

@wtfiwtz wtfiwtz requested a review from abottega June 13, 2024 00:04
@wtfiwtz
Copy link
Contributor Author

wtfiwtz commented Jun 13, 2024

Fixed in #292 and #291

@wtfiwtz wtfiwtz closed this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants