accept non-promise callbacks #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -7,7 +7,7 @@ function Task( | |||
| producer: Producer, | |||
| topic: string, | |||
| subscribeCallback: Callback) { | |||
| const subscribe = (payload: any) => subscribeCallback(payload); | |||
| const subscribe = (payload: any) => Promise.resolve(subscribeCallback(payload)); | |||
There was a problem hiding this comment.
should we check like this?
src/runner.js
Outdated
| const task = registry.getTask(topic); | ||
| await task.subscribe(JSON.parse(m.message.value.toString('utf8'))); // eslint-disable-line | ||
| await consumer.commitOffset({ topic, partition, offset: m.offset, metadata: 'optional' }); // eslint-disable-line |
There was a problem hiding this comment.
if subscribe throws error, commit won't execute.. Is it ok? 🤔
johndagostino
force-pushed
the
feature/callback
branch
from
9125160 to
3958feb
Compare
zcapper
added a commit
that referenced
this pull request
Jan 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
accept non-promise callbacks
Describe the overall goal(s) of the pull request's commits.
Changes
List the main changes in this PR.
Testing Instructions
Outline the steps to test or reproduce the PR.
Screenshots
(if appropriate, they help the reviewer visualise the changes)