Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ORL-63] Toon shader outlines w/o stencil #58

Open
daalta opened this issue Dec 17, 2023 · 3 comments
Open

[ORL-63] Toon shader outlines w/o stencil #58

daalta opened this issue Dec 17, 2023 · 3 comments
Labels
feature Feature reqyuests linear Created by Linear-GitHub Sync Toon Created by Linear-GitHub Sync
Milestone

Comments

@daalta
Copy link

daalta commented Dec 17, 2023

The current toon shader uses stencils to achieve its stencil effects. This effect has benefits when dealing with transparency. But it's sometimes less effective at rendering concave outlines or outlines that intersect with the mesh.

I'd appreciate being able to choose between stencil-based outlines and "traditional" outlines.

Here's a comparison between orels's toon shader and Poyomi.

orels vs poyomi

Here's an example of outlines not being rendered in certain conditions:

outlines

From SyncLinear.com | ORL-63

@daalta daalta added the feature Feature reqyuests label Dec 17, 2023
@orels1
Copy link
Owner

orels1 commented Dec 24, 2023

Unity_bP3wC8XF6p.mp4

I think i got it working with a simple toggle

@orels1
Copy link
Owner

orels1 commented Dec 24, 2023

That would allow shapes that overlap each other to have stencils. I'll probably rename it to something more human readable

@orels1 orels1 added the linear Created by Linear-GitHub Sync label Dec 24, 2023
@orels1 orels1 changed the title Toon shader outlines w/o stencil [ORL-63] Toon shader outlines w/o stencil Dec 24, 2023
orels1 added a commit that referenced this issue Dec 24, 2023
- closes [ORL-63] Toon shader outlines w/o stencil #58
@orels1 orels1 added the Toon Created by Linear-GitHub Sync label Jan 6, 2024
@orels1 orels1 added this to the ORL Shaders milestone Jan 6, 2024
@orels1
Copy link
Owner

orels1 commented Jan 7, 2024

Added support for modifying outline width by vertex color. This will allow better artistic control

orels1 added a commit that referenced this issue Jan 7, 2024
- Addresses [ORL-63] Toon shader outlines w/o stencil #58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature reqyuests linear Created by Linear-GitHub Sync Toon Created by Linear-GitHub Sync
Projects
None yet
Development

No branches or pull requests

2 participants