Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ORL-75] Ambient Occlussion doesn't occlude specular on Avatars #76

Open
orels1 opened this issue Jul 11, 2024 · 2 comments
Open

[ORL-75] Ambient Occlussion doesn't occlude specular on Avatars #76

orels1 opened this issue Jul 11, 2024 · 2 comments
Assignees
Labels
bug Something isn't working Generator Created by Linear-GitHub Sync PBR Created by Linear-GitHub Sync

Comments

@orels1
Copy link
Owner

orels1 commented Jul 11, 2024

Seems like AO map doesn't participate in Specular Occlusion calculation on non-baked meshes

From SyncLinear.com | ORL-75

@orels1 orels1 self-assigned this Jul 11, 2024
@orels1 orels1 added bug Something isn't working Generator Created by Linear-GitHub Sync PBR Created by Linear-GitHub Sync labels Jul 11, 2024
@orels1
Copy link
Owner Author

orels1 commented Jul 11, 2024

After some investigation - this is what the issue turned out to be:

When the object has Baked Specular enabled and isn't lightmapped - the lightprobe light direction is used to create specular highlights (otherwise metallic objects would be incredibly flat).

However, that specular contribution was added directly to the final direct specular, which does not get specular occlusion applied to it (should it? not sure).

I adjusted the logic so that direct specular derived from lightmaps or lightprobes gets its specular adjusted correctly as well.

I also added a relevant slider in case this new effect makes the objects too dark

NVIDIA_Overlay_NHkIwwrfVP.mp4

@orels1
Copy link
Owner Author

orels1 commented Aug 13, 2024

After lots of tweaking and renaming things - there should now be options to make this look how you want it to look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Generator Created by Linear-GitHub Sync PBR Created by Linear-GitHub Sync
Projects
None yet
Development

No branches or pull requests

1 participant