Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] Update missions displayed on the map on save #51

Merged
merged 1 commit into from
Aug 11, 2020
Merged

[UI] Update missions displayed on the map on save #51

merged 1 commit into from
Aug 11, 2020

Conversation

ngyewch
Copy link
Member

@ngyewch ngyewch commented Aug 11, 2020

Fix for #50

@ngyewch ngyewch added bug Something isn't working ui User Interface starcontrol-2020 StarControl 2020 labels Aug 11, 2020
@ngyewch ngyewch requested a review from tbkoay August 11, 2020 04:21
@tbkoay
Copy link
Collaborator

tbkoay commented Aug 11, 2020

missionDefinitions.missions.length <= index
Would the missions.length go > index?

@tbkoay tbkoay merged commit 1a74ff0 into dev Aug 11, 2020
@ngyewch ngyewch deleted the feature/webui-mission-save-update-fix branch August 20, 2020 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbkoay tbkoay tbkoay approved these changes

Assignees
No one assigned
Labels
bug Something isn't working starcontrol-2020 StarControl 2020 ui User Interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ngyewch @tbkoay