Replies: 5 comments 4 replies
-
I would discourage getting into versioning and stay evergreen. If you really want/need/have to do versioning, I'd strongly recommend doing proper releases similar to mas as seen here - rather than akamai magic and living in separate branches. We should stay consistent in the approach within the repo. There are similar discussions for mas that happened |
Beta Was this translation helpful? Give feedback.
-
Related discussion https://github.com/orgs/adobecom/discussions/2792 |
Beta Was this translation helpful? Give feedback.
-
Fully agree with @mokimo, there's already an established pattern for such use-cases, that would likely be the better path. Special branches + Akamai rules sound quite non-transparent, which we want to avoid. |
Beta Was this translation helpful? Give feedback.
-
@overmyheadandbody @mokimo We could get this in as a temporary solution so we can make it by 11/12, and then have another ticket for implementing a better approach (a bundling approach) after that. Would that be acceptable? cc: @salonijain3 |
Beta Was this translation helpful? Give feedback.
-
We will be going with the bundling approach targeted for 3/12 rollout. |
Beta Was this translation helpful? Give feedback.
-
Milo "releases" (so called because technically Milo/EDS do continuous delivery but we have a staging process) fairly quickly, too quick for most standalone gnav consumers. We need to have a release process for changes in standalone gnav. The ersatz solution is to maintain two separate branches from
main
, calledstage-feds-gnav
andfeds-gnav
, and every two weeks mergemain
intostage-feds-gnav
and thenstage-feds-gnav
intofeds-gnav
.We'll have an Akamai rule that redirects any requests going to www.adobe.com/feds-gnav/ to feds-gnav-milo--adobecom.hlx.live/libs/ (by the same token, requests to www.stage.adobe.com/feds-gnav/ go to stage-feds-gnav--milo--adobecom.hlx.live/libs/). This way standalone gnav consumers will be able to access a slightly stale, but safe version of the code while still hitting
www.adobe.com
for the Gnav.related PR: #3113
Beta Was this translation helpful? Give feedback.
All reactions