MWPW-161273 Standalone Gnav needs a release cycle #3113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert "MWPW-156749: Fix video CLS (adobecom#2849)" This reverts commit d4134c8.
fix quiz marquees
adobecom#3014) [MWPW-159328] handle a case where there are not placeholders available (adobecom#2998) * [MWPW-159328] handle a case where there are not palceholders availble * fixed typos --------- Co-authored-by: Denys Fedotov <denlight@gmail.com> Co-authored-by: Denys Fedotov <dfedotov@Denyss-MacBook-Pro.local>
…adobecom#3023) * stash * stash * stash * working well * set updated command list for inline * remove querySelector function * unit test and custom block fix * updates for in-block * merch-card-collection unit test fixed * unit test updates * more unit test repair * linting errors * more linting * Fix Invalid selector test * add coverage * force git checks to refire * remove comment * pass rootEl to getSelectedElements for use when needed (gnav) * skip if clause in codecov --------- Co-authored-by: Vivian A Goodrich <101133187+vgoodric@users.noreply.github.com> Co-authored-by: markpadbe <markp@adobe.com>
…becom#2991) * Revert "MWPW-156749: Fix video CLS " (adobecom#2899) (adobecom#2900) Revert "MWPW-156749: Fix video CLS (adobecom#2849)" This reverts commit d4134c8. * Changing z-index of promobar and popup * Changing z-index of promobar and popup * Reverting z-index to 4 for promobar --------- Co-authored-by: milo-pr-merge[bot] <169241390+milo-pr-merge[bot]@users.noreply.github.com> Co-authored-by: Okan Sahin <39759830+mokimo@users.noreply.github.com> Co-authored-by: Blaine Gunn <Blainegunn@gmail.com> Co-authored-by: Akansha Arora <>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## stage #3113 +/- ##
==========================================
- Coverage 96.43% 96.33% -0.10%
==========================================
Files 245 247 +2
Lines 55746 56235 +489
==========================================
+ Hits 53757 54174 +417
- Misses 1989 2061 +72 ☔ View full report in Codecov by Sentry. |
mokimo
reviewed
Oct 31, 2024
| import(`${miloLibs}/libs/utils/utils.js`), | ||
| import(`${miloLibs}/navigation/bootstrapper.js`), | ||
| import(`${miloLibs}/utils/locales.js`), | ||
| import(`${miloLibs}//utils/utils.js`), |
There was a problem hiding this comment.
Suggested change
| import(`${miloLibs}//utils/utils.js`), | |
| import(`${miloLibs}/utils/utils.js`), |
|
superceded by #3132 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Milo "releases" (so called because techincally Milo/EDS do continuous delivery but we have a staging process) fairly quickly, too quick for most standalone gnav consumers. We need to have a release process for changes in standalone gnav. The ersatz solution is to maintain a separate branch from main, called feds-gnav, and every two weeks merge main into this separate branch.
We'll have an Akamai rule that redirects any requests going to
www.adobe.com/feds-gnav/tofeds-gnav-milo--adobecom.hlx.live/libs/(by the same token, requests towww.stage.adobe.com/feds-gnav/go tostage-feds-gnav--milo--adobecom.hlx.live/libs/)To support the above change we also need to change navigation.js to point to /feds-gnav/* instead of /libs/* in the miloLibs portion of the config.
Resolves: MWPW-161273
Test URLs: