Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes git-cliff-completions and git-cliff-mangen optional feature #115

Closed
azzamsa opened this issue Oct 3, 2022 · 5 comments
Closed

Makes git-cliff-completions and git-cliff-mangen optional feature #115

azzamsa opened this issue Oct 3, 2022 · 5 comments
Assignees
Labels
feature/request New feature or request

Comments

@azzamsa
Copy link

azzamsa commented Oct 3, 2022

Is your feature request related to a problem? Please describe.
We prefer to install git-cliff via cargo-binstall. It fetches the binary directly from the Github release. However, the compressed file only contains git-cliff binary, missing git-cliff-completions and git-cliff-mangen. Making the installations fails.

Describe the solution you'd like
Use required-features to makes git-cliff-completions and git-cliff-mangen optional.

Describe alternatives you've considered
Provide git-cliff-completions and git-cliff-mangen binary in the release file.

Additional context
Related:

@azzamsa azzamsa added the feature/request New feature or request label Oct 3, 2022
@azzamsa
Copy link
Author

azzamsa commented Oct 3, 2022

If this is OK, I am ready to make a PR.

@orhun
Copy link
Owner

orhun commented Oct 6, 2022

Sounds good, feel free to submit a PR!

@azzamsa
Copy link
Author

azzamsa commented Oct 7, 2022

Reading the-required-features-field documentation multiple times doesn't give my any clue. Googling also doesn't help.

I opened a draft PR #118 here. But I have no clue of what I am doing.

Would you like to give me some guidance?

@orhun
Copy link
Owner

orhun commented Oct 8, 2022

I'm not sure if #118 changes anything. It just adds an empty required-features to both binaries. I'd rather go with the second approach and include the binaries in the release assets.

@orhun
Copy link
Owner

orhun commented Dec 22, 2022

We now include those binaries in releases: 9a070b2

@orhun orhun closed this as completed Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants