Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip all tags, when skip_tags = "" #136

Closed
hituzi-no-sippo opened this issue Jan 13, 2023 · 2 comments
Closed

Skip all tags, when skip_tags = "" #136

hituzi-no-sippo opened this issue Jan 13, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@hituzi-no-sippo
Copy link

Describe the bug

Skip all tags, when skip_tags = "".

To Reproduce

I've created a test script.

test script
#!/bin/bash

set -e

rm -rf /tmp/cliff/skip_tags_test
mkdir -p /tmp/cliff/skip_tags_test
cd /tmp/cliff/skip_tags_test

git init

git commit --allow-empty -m "chore: v0.0.1"
git tag v0.0.1 --message v0.0.1

git commit --allow-empty -m "feat: v0.1.0-beta.1"
git tag v0.1.0-beta.1 --message v0.1.0-beta.1

git commit --allow-empty -m "feat: v0.1.0"
git tag v0.1.0 --message v0.1.0

git cliff --version

git cliff --init

echo '====================================='
echo 'skip_tags = "v0.1.0-beta.1" (Default)'
echo '====================================='
git cliff

sed -i 's/\(skip_tags = \)"v0.1.0-beta.1"/\1""/' cliff.toml
echo '====================================='
echo 'skip_tags = ""'
echo '====================================='
git cliff

sed -i 's/skip_tags.*//' cliff.toml
echo '====================================='
echo 'skip_tags is unset.'
echo '====================================='
git cliff
output
Initialized empty Git repository in /tmp/cliff/skip_tags_test/.git/
[main (root-commit) 48e1819] chore: v0.0.1
[main 7b79e50] feat: v0.1.0-beta.1
[main e1ca355] feat: v0.1.0
git-cliff 1.1.1
 INFO  git_cliff > Saving the configuration file to "cliff.toml"
=====================================
skip_tags = "v0.1.0-beta.1" (Default)
=====================================
# Changelog

All notable changes to this project will be documented in this file.

## [0.1.0] - 2023-01-13

### Features

- V0.1.0

## [0.0.1] - 2023-01-13

### Miscellaneous Tasks

- V0.0.1

<!-- generated by git-cliff -->
=====================================
skip_tags = ""
=====================================
# Changelog

All notable changes to this project will be documented in this file.

<!-- generated by git-cliff -->
=====================================
skip_tags is unset.
=====================================
# Changelog

All notable changes to this project will be documented in this file.

## [0.1.0] - 2023-01-13

### Features

- V0.1.0

## [0.1.0-beta.1] - 2023-01-13

### Features

- V0.1.0-beta.1

## [0.0.1] - 2023-01-13

### Miscellaneous Tasks

- V0.0.1

<!-- generated by git-cliff -->

skip_tags = ""

# Changelog

All notable changes to this project will be documented in this file.

<!-- generated by git-cliff -->

Expected behavior

I expect don't skip all tags, as when skip_tags is unset.

skip_tags is unset.

# Changelog

All notable changes to this project will be documented in this file.

## [0.1.0] - 2023-01-13

### Features

- V0.1.0

## [0.1.0-beta.1] - 2023-01-13

### Features

- V0.1.0-beta.1

## [0.0.1] - 2023-01-13

### Miscellaneous Tasks

- V0.0.1

<!-- generated by git-cliff -->

System (please complete the following information):

  • OS Ubuntu 20.04 LTS (WSL2)
  • Project Version: v1.1.1

Additional context

It seems to be caused by 8b17a1f.
The bug occurs in 8b17a1f, but not in ce1b7c3.

Thank you.

@hituzi-no-sippo hituzi-no-sippo added the bug Something isn't working label Jan 13, 2023
orhun added a commit that referenced this issue Jan 13, 2023
@orhun
Copy link
Owner

orhun commented Jan 13, 2023

Hey, thank you for reporting! 🐻

Indeed, this is is a regression in 8b17a1f and should be fixed via eee35ad.

@orhun orhun closed this as completed Jan 13, 2023
@hituzi-no-sippo
Copy link
Author

Good job 👍

I've checked, it worked as expected.
Thank you 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants