Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail to save JSON context #138

Closed
shmpwk opened this issue Jan 18, 2023 · 2 comments
Closed

Fail to save JSON context #138

shmpwk opened this issue Jan 18, 2023 · 2 comments
Assignees
@orhun
Labels
bug Something isn't working

Comments

@shmpwk
Copy link

shmpwk commented Jan 18, 2023 •
edited
Loading

Describe the bug
git-cliff v1.0.0 (current v1.1.1 also) cannot save the JSON context though v0.10.0 can.

To Reproduce
Steps to reproduce the behavior:

  1. cargo install git-cliff --version 1.0.0
  2. git cliff --init
  3. git cliff --context --output context.json
  4. context.json file is not created, but is printed to stdout.

Expected behavior
If we execute this, we can get context.json
git cliff --context --output context.json

System

  • Ubuntu 20.04
  • cargo 1.63.0 (fd9c4297c 2022-07-01)

Fail version: git-cliff v1.0.0 (v1.1.1)
Success version: git-cliff v0.10.0
@shmpwk shmpwk added the bug Something isn't working label Jan 18, 2023
orhun added a commit that referenced this issue Jan 18, 2023
@orhun
fix(changelog): allow saving context to a file (#138)
08ea900
@orhun
Copy link
Owner

orhun commented Jan 18, 2023

Thanks for reporting! 🐻 This should be fixed in 08ea900

@orhun orhun closed this as completed Jan 18, 2023
@shmpwk
Copy link
Author

shmpwk commented Jan 19, 2023

Thank you for your quick fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@orhun orhun

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@orhun @shmpwk