Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.3.0-rc Release notes #249

Closed
joshka opened this issue Aug 21, 2023 · 2 comments
Closed

1.3.0-rc Release notes #249

joshka opened this issue Aug 21, 2023 · 2 comments
Assignees
@orhun
Labels
bug Something isn't working

Comments

@joshka
Copy link
Contributor

joshka commented Aug 21, 2023

Describe the bug

This is a bit of a multi-part issue.

  • git cliff notifies of rc releases that can't be installed by cargo install (unless explicitly selected I guess).
  • Latest release notes for 1.3.0-rc1 were formatted weird (since been fixed via chat with Orhun)
  • release notes for 1.3.0-rc0 and rc1 had commits from 1.2.0 in them (also fixed)

To reproduce

Expected behavior

Screenshots / Logs

Software information

  • Operating system:
  • Rust version:
  • Project version:

Additional context
@joshka joshka added the bug Something isn't working label Aug 21, 2023
@welcome
Copy link

welcome bot commented Aug 21, 2023

Thanks for opening your first issue at git-cliff! Be sure to follow the issue template! ⛰️

orhun added a commit that referenced this issue Aug 21, 2023
@orhun
fix(cd): do not publish release notes for pre-releases (#249)
7a82aa1
orhun added a commit that referenced this issue Aug 21, 2023
@orhun
fix(informer): do not inform about pre-releases (#249)
87e47e6
@orhun
Copy link
Owner

orhun commented Aug 21, 2023

Fixed in 7a82aa1 and 87e47e6

@orhun orhun closed this as completed Aug 21, 2023
@ZhongRuoyu ZhongRuoyu mentioned this issue Aug 31, 2023
Closed
@nekofar nekofar mentioned this issue Sep 2, 2023
Closed
@BrewTestBot BrewTestBot mentioned this issue Sep 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@orhun orhun

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joshka @orhun