Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use regex for tag_pattern #289

Closed
PoisonPhang opened this issue Sep 19, 2023 · 2 comments · Fixed by #318
Closed

Use regex for tag_pattern #289

PoisonPhang opened this issue Sep 19, 2023 · 2 comments · Fixed by #318
Assignees
Labels
feature/request New feature or request good first issue Good for newcomers

Comments

@PoisonPhang
Copy link

Is your feature request related to a problem? Please describe.

I find myself struggling to define a sem-version filter using basic glob filtering that is used when parsing tag_pattern. This is especially annoying when all other tag filtering fields (skip_tags and ignore_tags) use regex.

Describe the solution you'd like

It would be great if we could use regex (or even extglob) to define tag_pattern.

@PoisonPhang PoisonPhang added the feature/request New feature or request label Sep 19, 2023
@welcome
Copy link

welcome bot commented Sep 19, 2023

Thanks for opening your first issue at git-cliff! Be sure to follow the issue template! ⛰️

@woshilapin
Copy link
Contributor

I'll take a stab at this one.

woshilapin added a commit to woshilapin/git-cliff that referenced this issue Oct 15, 2023
woshilapin added a commit to woshilapin/git-cliff that referenced this issue Oct 15, 2023
BREAKING CHANGE: `tag_pattern` now takes a valid regular expression instead of a glob pattern

resolves orhun#289
woshilapin added a commit to woshilapin/git-cliff that referenced this issue Oct 15, 2023
BREAKING CHANGE: `tag_pattern` now takes a valid regular expression instead of a glob pattern

resolves orhun#289
woshilapin added a commit to woshilapin/git-cliff that referenced this issue Oct 15, 2023
BREAKING CHANGE: `tag_pattern` now takes a valid regular expression instead of a glob pattern

resolves orhun#289
woshilapin added a commit to woshilapin/git-cliff that referenced this issue Oct 16, 2023
BREAKING CHANGE: `tag_pattern` now takes a valid regular expression instead of a glob pattern

resolves orhun#289
woshilapin added a commit to woshilapin/git-cliff that referenced this issue Oct 21, 2023
BREAKING CHANGE: `tag_pattern` now takes a valid regular expression instead of a glob pattern

resolves orhun#289
woshilapin added a commit to woshilapin/git-cliff that referenced this issue Oct 27, 2023
BREAKING CHANGE: `tag_pattern` now takes a valid regular expression instead of a glob pattern

resolves orhun#289
@orhun orhun assigned woshilapin and unassigned orhun Oct 29, 2023
orhun pushed a commit that referenced this issue Oct 29, 2023
resolves #289

BREAKING CHANGE: `tag_pattern` now takes a valid regular expression instead of a glob pattern
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/request New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants