Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommitParser, Regex Capture group not resolved in scope #371

Closed
Lerosen opened this issue Dec 7, 2023 · 2 comments · Fixed by #372
Closed

CommitParser, Regex Capture group not resolved in scope #371

Lerosen opened this issue Dec 7, 2023 · 2 comments · Fixed by #372
Assignees
Labels
bug Something isn't working

Comments

@Lerosen
Copy link

Lerosen commented Dec 7, 2023

Describe the bug

The regex of the following commit_parser declares a capture group that should be accessible with ${1} according to the examples.
This works fine for the group attribute but not for the scope. I don't use the conventional commit message format and therefore would like to extract the scope dynamically as well.

{ message = "^\\[(.*)\\]", group = "Changes to ${1}", scope = "${1}" },

To reproduce

Expected behavior

group=my_scope and scope=my_scope

Screenshots / Logs

Software information

  • Operating system:
  • Rust version:
  • Project version:

Additional context

@Lerosen Lerosen added the bug Something isn't working label Dec 7, 2023
Copy link

welcome bot commented Dec 7, 2023

Thanks for opening your first issue at git-cliff! Be sure to follow the issue template! ⛰️

@Lerosen Lerosen changed the title CommitParser, Regex Capture group not added in scope CommitParser, Regex Capture group not resolved in scope Dec 7, 2023
@orhun
Copy link
Owner

orhun commented Dec 7, 2023

Hello, thanks for reporting!

Implemented in #372 🐻

@orhun orhun closed this as completed in #372 Dec 7, 2023
orhun added a commit that referenced this issue Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants